search

AgileVentures / projectscope

MVP dashboard for ProjectScope, using new gems architecture developed by AV folks
2 stars 14 forks source link

seed data through 14 days range #62

Closed junyu-w closed 7 years ago

junyu-w commented 7 years ago

pt: https://www.pivotaltracker.com/story/show/133294131

added seed file + seed images to generate data from today to 14 days ago (so that timeline slider can be tested)

junyu-w commented 7 years ago

@tansaku updated :)

tansaku commented 7 years ago

Thanks @DrakeW - the only thing that makes me a little nervous about this seed data is that it reflects a certain state of the gems. So if the gems change later, then the seed data will become out of date. I guess it's no different than any fixture data that might be associated with the text environment, but at least there we have VCR caches that can easily be deleted and regenerated with accurate data from the network.

Maybe I'm worrying about nothing, but shouldn't the key thing here be tests that work with VCR caches or fixtures so that we have automated tests that can check that some slider works, rather than having seed data to check it manually. Does that make sense?

junyu-w commented 7 years ago

@tansaku yea the codeclimate data is dependent on the gem in our seed file.. I wanted to change them to use hardcoded svg files too but I didn't find any sample badge online.

and yea we should definitely use VCR and fixtures to do our automated testing for slider, but this PR is not trying to replace automate testing, instead it's just a tool to help visualize the slider stuff for developer and provide seed data for our customer to play with on the staging website :)

Not quite sure if I addressed your concern... but let me know if I was on the wrong track of this conversation lol

tansaku commented 7 years ago

@DrakeW yeah - I understand the desire to have some data to test the slider manually - but is the slider in place already? I don't remember merging that ...

junyu-w commented 7 years ago

@tansaku It's not PR-ed yet, but functionality has been finished and I'll be adding test to its own feature branch later :)

junyu-w commented 7 years ago

@tansaku actually, should I just include this in the timeslider feature pr?

but that might make that PR touch a lot of files...

tansaku commented 7 years ago

that's fine - this can stand alone