search

AgileVentures / projectscope

MVP dashboard for ProjectScope, using new gems architecture developed by AV folks
2 stars 14 forks source link

BUGFIX/sort caused duplicate items #63

Closed junyu-w closed 7 years ago

junyu-w commented 7 years ago

PT story: https://www.pivotaltracker.com/story/show/134337421

  1. fixed bug caused by incorrect query
tansaku commented 7 years ago

No test to cover this bug?

Ideally, anytime we have a bug, we write a test to ensure that the debug does not recur, and to have a mechanism to ensure that it really is fixed ...

junyu-w commented 7 years ago

@tansaku it's weird that test failed on CI but passed locally...looks like the projects were not actually created in the test db on CI.

Did this happen to other rspec tests before?

tansaku commented 7 years ago

@DrakeW have not seen this before ... I've restarted the build ...

junyu-w commented 7 years ago

@tansaku creating projects with metric_samples using factory fixed the problem :)

tansaku commented 7 years ago

@DrakeW glad the build is green. Do we want acceptance (i.e. cucumber) tests for bug fixes?

junyu-w commented 7 years ago

@tansaku I think it's ok to leave acceptance test for the bug fix since I don't think there are any missing part for this bug fix that Rspec didn't cover