AgileVentures / projectscope

MVP dashboard for ProjectScope, using new gems architecture developed by AV folks
2 stars 14 forks source link

Add delayed_job gem to handle resample. #67

Closed an-ju closed 7 years ago

an-ju commented 7 years ago

I added delayed_job gem to handle asynchronous jobs. Including this gem will provide necessary infrastructure to handle more complex functionalities (such as grading as I'm about to work on). Adding this gem requires enabling delayed_job worker on heroku side, which is free to use.

I added a resample button in the index page so that TAs can get instant feedback.

There is no test.

tansaku commented 7 years ago

@an_ju - you might also want to consider using the heroku scheduler that allows us to manage hourly and daily tasks - simply create the rake task for what you need.

I'm not inclined to merge code that doesn't have tests. We need a specific feature describing what things are for, with acceptance tests to drive that feature before we can justify adding code to the project.

My suspicion is that we don't actually need this and that plain heroku scheduling can handle everything you need. If it can't let's hear the specific user stories - thanks

an-ju commented 7 years ago

Right. After another talk with Armando, I think this feature doesn't need to be added to ProjectScope right now.

The story was to enable real-time resampling, which might take a very long time so should be run in background.

I'll close this PR. Thanks for reviewing!