Closed FedericoEsparza closed 5 years ago
fixes #42 fixes #41 fixes #40
.tool-versions
mix phx.new .
mix phx.gen.json Artists Artist artists name:string
ncu -u && npm install
System.get_env("POSTGRES_USERNAME")
System.get_env("POSTGRES_PASSWORD")
@moduledoc false
artist.ex
2301 cd sing_for_needs/ 2302 git checkout -b 42-Try-regenerating-new-phx-1.4-project-with-ecto-and-Artist-api-resource 2303 asdf current 2304 code . 2305 asdf current 2306 rm -rf .elixir_ls/ 2307 rm -rf ./.elixir_ls/ 2308 rm -rf ./assets/ 2309 rm -rf ./config/ 2310 rm -rf ./deps/ 2311 rm -rf ./priv/ 2312 rm -rf ./test/ 2313 rm -rf ./lib/ 2314 rm .formatter.exs 2315 rm mix.exs 2316 rm mix.lock 2317 mix archive.install hex phx_new 1.4.2 2318 rm -rf ./.elixir_ls/ 2319 git add -A 2320 git s 2321 git commit -m"strip project except for some root config files and README" 2322 mix phx.new . 2323 mix ecto.create 2324 git add -A 2325 git s 2326 git commit -m"run mix phx.new ." 2327 mix ecto.create 2328 mix test 2329 mix phx.server 2330 mix phx.gen.json Artists Artist artists name:string 2331 code lib/sing_for_needs_web/router.ex 2332 mix ecto.migrate 2333 mix ecto.migrate 2334 mix ecto.migrate 2335 mix ecto.create 2336 mix ecto.migrate 2337 mix test 2338 mix phx.server 2339 git add -A 2340 git s 2341 git push 2342 git push --set-upstream origin 42-Try-regenerating-new-phx-1.4-project-with-ecto-and-Artist-api-resource 2343 git commit -m"run mix phx.gen.json Artists Artist artists name:string AND add resource to /api scope" 2344 git push 2345 cd assets && npm audit 2346 node -v 2347 ncu -u 2348 npm install 2349 npm audit 2350 git add -A 2351 git s 2352 git commit -m"run ncu -u && npm install in /assets" 2353 git push 2354 git s 2355 git diff 2356 git commit -am"Change elixir version to 1.8 in mix.exs" 2357 git push 2358 cd .. && mix deps.get 2359 git add -A 2360 git s 2361 git commit -m"Re-add credo" 2362 git push 2363 mix test 2364 mix phx.server 2365 git s 2366 git add -A 2367 git commit -m'Re-add System.get_env("POSTGRES_USERNAME") & System.get_env("POSTGRES_PASSWORD")' 2368 git push 2369 history 60 2370 history 80 2371 mix credo 2372 git add -A 2373 git commit -m"Add @moduledoc false to artist.ex" 2374 git push 2375 history 10
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/AgileVentures/sing_for_needs/pulls/43.
fixes #42 fixes #41 fixes #40
.tool-versions
to 1.8.1-otp-20mix phx.new .
mix phx.gen.json Artists Artist artists name:string
AND added resource to /api scopencu -u && npm install
in /assetsSystem.get_env("POSTGRES_USERNAME")
&System.get_env("POSTGRES_PASSWORD")
@moduledoc false
toartist.ex