daumie commented 5 years ago

For PR  ### What does this PR do?

Creates a Template to be filled when creating Pull Requests

Description of Task to be completed?

Add PULL_REQUEST_TEMPLATE.md with desired template sections.

How should this be manually tested?

After this particular PR has been merged. You should be able to see a Pull Request template for subsequent PR's.

Any background context you want to provide?

Pull request templates help guide developers make better software, and a better software development experience.
They are obviously extremely useful for open source projects that get many contributions from outsiders, but they can also be very useful for internal projects where all contributors are insiders.
They codify and encourage good behavior, thoughtful code, and empathetic interactions with teammates.
They normalize and reinforce a workflow regardless of size, scope, or underlying technology used in a project.
And they provide consistency and familiarity that makes switching between multiple projects per day a little easier.

What are the relevant Github Issues ?

48

Screenshots (If applicable)

Here's a peek of the created template

yakryder commented 5 years ago

Great change!

yakryder commented 5 years ago

@daumie I believe @FedericoEsparza wants us not to delete branches, and I believe the reasoning is that this makes for easier history visualization. This should be doc'ed in CONTRIBUTING or equivalent if it isn't

daumie commented 5 years ago

@SherSpock Thanks you for bringing this up. @aonomike Where can we have this specified?

AgileVentures / sing_for_needs

Create Github Pull Request Template #52

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant Github Issues ?

48

Screenshots (If applicable)