search

AgileVentures / sing_for_needs

Prototype
4 stars 12 forks source link

Feature/login #78

Closed siddhant3030 closed 5 years ago

siddhant3030 commented 5 years ago

I have worked on model and schema for a user to login. User can Sign-up first which will give hash password to the backend. After Sign-in the user will receive an auth-token. But this branch is work on progress. I still have to create a controller for this.

sourcelevel-bot[bot] commented 5 years ago

SourceLevel has finished reviewing this Pull Request and has found:

You can see more details about this review at https://app.sourcelevel.io/github/AgileVentures/sing_for_needs/pulls/78.

aonomike commented 5 years ago

Hi @siddhant3030 are you planing to have a look at this PR? we can plan a pairing session :)

yakryder commented 5 years ago

@siddhant3030 Thanks for your contribution. Please do some reading on contexts in Phoenix 1.3 before continuing further -- this will likely save you a lot of pushback once it's ready for review. It sounds like Mike would be happy to pair with you on this

yakryder commented 5 years ago

@siddhant3030 Thank you for taking a look at user auth! I'm afraid this PR has grown stale and contains unmergeable work. If you'd like to continue this valuable work please do so in another PR. We'd be very happy to review it. I'm also sure someone on the team would be happy to work with you on it if you prefer.

Thanks!