search

AgileWorksOrg / elasticsearch-river-csv

CSV river for ElasticSearch
Apache License 2.0
91 stars 45 forks source link

Adding fieldParent #32

Closed flavianh closed 9 years ago

vtajzich commented 10 years ago

Please, provide unit test also.

vtajzich commented 10 years ago

Please, update this pull request to accommodate latest changes and add test for your changes.

flavianh commented 10 years ago

OK I'll look into that after the 17

vtajzich commented 10 years ago

@traxair could, you,please, update your pull request? We are going to release new version, it would be great If it will be part of it.

flavianh commented 10 years ago

So sorry @vtajzich, we have work all over our heads here... I'd have to dig into your unit tests system which I am not familiar with. The way the modification work is the following though: If the CSV has a field named _parent, then we use the elasticsearch spectific function for the "_parent" value.

vtajzich commented 10 years ago

@traxair I'm too busy as well. As nobody else asked for this feature, it can wait. Please, update this pull request when you have time. Thanks

IsraelWebDev commented 9 years ago

I want this!

vtajzich commented 9 years ago

As @traxair is not responding I'll do it myself. Closing this pull request and do it as common feature.