search

Aginix / nestjs-firebase-admin

Firebase Admin Module for Nest.js Framework
MIT License
108 stars 37 forks source link

Class 'FirebaseAuthenticationService' incorrectly implements interface 'Auth'. #119

Closed LynX39 closed 4 years ago

LynX39 commented 4 years ago

Using npm package the Auth interface is incorrectly implements:

ERROR in /Users/michaelmusso/Workspace/NestJS/klasse-uno-core/node_modules/@aginix/nestjs-firebase-admin/dist/services/firebase-admin-authentication.service.d.ts(2,22):
TS2420: Class 'FirebaseAuthenticationService' incorrectly implements interface 'Auth'.
  Type 'FirebaseAuthenticationService' is missing the following properties from type 'Auth': deleteUsers, getUsers

Add two methods implements deleteUsers and getUsers. If I have a time resolve in a PR. Assign to @LynX39 please.

n3n commented 4 years ago

Thank you, v1.0.6 released!

LynX39 commented 4 years ago

Good!!!