search

Agneese-Saini / SA-MP

Apache License 2.0
66 stars 118 forks source link

Clarification on weapon_damage.inc #22

Closed Chaprnks closed 6 years ago

Chaprnks commented 6 years ago

I've noticed that alot of very useful scripts come & go on this repository, but unfortunately there's not much of an announcement when this ever happens. What's even more suprising, is it's not even listed on the repositories README.md

Since hitreg.inc is supposedly abandoned/removed from the repository, is weapon_damage supposed to be the new version of it or something?

Also, it looks strikingly similar to weapon-config, so it makes me wonder; do I need to implement SKY plugin as well? Since weapon-config was abandoned long ago, with some nasty bugs hidden.. this new mysterious weapon_damage just might be my perfect solution :D

Thanks again for all your hard work, cracking out code Gammix!

Chaprnks commented 6 years ago

I was also curious about EnterExit.pwn. I was about to implement this, but unfortunately textanims.inc has dissapeared, & it's predecessor fader.inc doesn't have any similar/compatible functions to port it into the new include.

Agneese-Saini commented 6 years ago

I have been very lazy in maintaining this whole repo!

To answer your questions, yes weapon_damage.inc is kinda newer version of hitreg.inc, but it's not tested at all, i just coded it one day and it would be great if someone can beta test it and report bugs! EnterExit.pwn, i'll fix it soon with fader.inc implementation! And also i have to update Readme.md heavily too :(

Chaprnks commented 6 years ago

Excellent! I'll test out the weapon_damage for you & report any bugs I encounter. If you want, I can convert the EnterExit functions to fader.inc & do a push/merge request :)

Agneese-Saini commented 6 years ago

Thanks, i already updated EnterExit though! I am working on updating Readm.md now!

Chaprnks commented 6 years ago

Having an odd issue with EnterExit, everything seems to be working fine, except the teleport. I walk up to the pickup & all around it, but no fade & no teleport.

Agneese-Saini commented 6 years ago

Should be fixed now! I did not converted it to streamer fully, before updating github!

Chaprnks commented 6 years ago

You forgot one, line 66 ;)

Chaprnks commented 6 years ago

Now it seems to be almost bug free! Pickup, teleport & fading works great, but I can't seem to get out of the interior. There's no visible pickup in the interior also (if there should be one)

Agneese-Saini commented 6 years ago

You have to create another EnterExit for inside.

Chaprnks commented 6 years ago

Okay, but don't you think it'd be much more efficient & simple to just add the exit functionality along with the entrance?

Agneese-Saini commented 6 years ago

It will make the enter exit array very lengthy, hard to read, in my opinion.

All you need to do for now is add another line for interior.

Chaprnks commented 6 years ago

The issue I have with doing it that way, is it puts me in an infinite loop of enter/exit

Agneese-Saini commented 6 years ago

Well don't make the exit pickup at the same spot of enterance teleport!

Chaprnks commented 6 years ago

Wow I feel like a complete idiot!

Anyways, do you think you can add RemovePlayerBuilding support for map_loader?

Agneese-Saini commented 6 years ago

Yes, i was gonna do that. Anyway, you know how it works? because i didn't provide any info on how it works!

Chaprnks commented 6 years ago

Yeah, I can get the jist of it from the code. Basically just input map_parse(const path[]); to the selected map. Although, without RemoveBuildingForPlayer, its basically useless for me =/

(Got like 152 maps in my script right now, fortunately its modulized in separate .pwn's in a folder.. but all those hooks are starting to cause issues with the script. Not to mention the added compile time)

Agneese-Saini commented 6 years ago

There you go! I added RemoveBuildingForPlayer in parser. Try it out, i haven't tested anything!

Chaprnks commented 6 years ago

Awesome, thanks! Finally found a perfect solution. Tried so many in the recent years (SSMM was way too complex & the editor program it came with kept crashing. the ADM or something one by the guy who makes 3dtryg include also was too complicated, cause it basically just compiled each map into its own filterscript, leaving me with hundreds of filterscripts on a single server.cfg)

Agneese-Saini commented 6 years ago

Alright, so you wanna close this issue, if you got your solution (i don't like open issues)!

Also checkout the README.md, i just updated it and also cleaned the Repo, removed some useless codes!