AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.
https://agnosticui.com
Apache License 2.0
724 stars 47 forks source link

Add on:sort event dispatcher #170

Closed Croug closed 2 years ago

Croug commented 2 years ago

Description

Adds svelte on:sort event to table

Checklist:

Croug commented 2 years ago

Not sure if you want this added to the docs at all, as it doesn't really fit the flow of the documentation style you have going, if you want me to add it to the docs in some way let me know where you want it.

roblevintennis commented 2 years ago

Right. So I think if you update the table pagination playground you recently created and added any sort of simple handler there (could even just log to console) that'd suffice. My plan is that playground will be "Code Sanbox" & "Stackblitz" button'd into both table and pagination docs 😄

Yeah, the docs are light on things like properties at the moment and leaning heavily on code examples instead.

Thanks @Croug -- I will just merge this and if you feel compelled to update the table pagination playground as I've suggested you can open a new PR for that. I appreciate all your contributions!

I'm thinking of how to best feature contributors (besides just what GitHub provides there) as the last time I had an open source project it was just me and a friend. If there's something idiomatic I should be doing please let me know. I'd like folks like you to feel incentives and get the glory you deserve 💪 🔥

Croug commented 2 years ago

@roblevintennis I'm still pretty new to contributing as well tbh haha, so I'm not sure. Just saw this project as potentially being something I could regularly use, and thought it would be something worthwhile to invest some time in. One suggestion I have however, is that it might be worthwhile to make a discord or slack for more free flowing communication, so we don't have to discuss future issues and prs from unrelated threads

roblevintennis commented 2 years ago

Absolutely I will try to get to a Slack or Discord soon 👍🏽