Make svelte pagination component less verbose

AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.

https://agnosticui.com

Apache License 2.0

724 stars 47 forks source link

Make svelte pagination component less verbose #173

Closed Croug closed 2 years ago

Croug commented 2 years ago

Description

Leans into the Svelte framework specific features to make the Pagination component less verbose

Implements #171

Checklist:

Please delete options that are not relevant.

[x] Is this a new feature
[x] Have you submitted new feature or bugfix issue? Unless it's a small bugix, we generally prefer to track PRs against an issue which starts a dialogue to give us context.
[x] Tests passing?
[x] Have you added to the framework's /examples apps? e.g. agnosticui-react/examples? These are kitchen sink sanity checks which help to verify a component is working and derive documentation snippets.
[x] Have you updated the docs? These live in site/docs

Croug commented 2 years ago

Started this pr so you could track progress, not quite finished still need to finish updating docs/examples

roblevintennis commented 2 years ago

This is looking great ❤️‍🔥

Let me know if you need any help on the docs and/or examples but I tested locally and your code is working 👍

You should also be aware of the mobile issue which I just rediscovered: https://github.com/AgnosticUI/agnosticui/issues/104

Since you're planning to use this in your app I'm assuming you'll be affected. We could:

I prioritize that issue as next thing I work on
You could give it a stab (and again it could be Svelte only if that keeps things moving and other frameworks would be optional for you to implement if you'd like or I could)

I'm fine with either of these so lmk whichever works best for you

Croug commented 2 years ago

I'm thinking after I finish this I'll take a stab at implementing offset/limit on the other frameworks then I can start on that issue you mentioned

Croug commented 2 years ago

Alright I've updated the docs and examples this should be ready to merge now unless you have any other requests

roblevintennis commented 2 years ago

This is looking great! Just a couple of change requests and/or questions 👍🏽

roblevintennis commented 2 years ago

This is still a work-in-progress correct? No rush, I just want to make sure I'm reviewing in a timely fashion on my end.

roblevintennis commented 2 years ago

Looks good -- merging