AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.
https://agnosticui.com
Apache License 2.0
723 stars 47 forks source link

allow content filtering based on header "key" prop #197

Closed Croug closed 2 years ago

Croug commented 2 years ago

Description

This PR adds a filterByKey flag for the Table component which allows columns to be re-arranged or even hidden based on the headers "key" property and order.

Fixes #191

Checklist:

Please delete options that are not relevant.

Croug commented 2 years ago

This PR is still a work in progress, I'll comment when it's ready to be merged

roblevintennis commented 2 years ago

Nice 👍🏽 reading from phone. Can you use the convert to draft mode for these so if doesn't get accidentally merged? When it's ready you can then convert back via the Ready for Review button at the bottom. Update: back on laptop was able to do this myself. Just hit Ready for Review when you're ready ;)

Croug commented 2 years ago

Ok cool, still new to the whole pull request process, didn't know that was an option!

netlify[bot] commented 2 years ago

Deploy Preview for agnostic-astro failed.

Name Link
Latest commit c51dcdcf7227a7b49fd9c2ee4fde280b90628f21
Latest deploy log https://app.netlify.com/sites/agnostic-astro/deploys/626ded5032c878000880d296
Croug commented 2 years ago

Added the storybook test, this is ready to be merged