search

AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.
https://agnosticui.com
Apache License 2.0
723 stars 47 forks source link

ChoiceInput checkbox has aria-hidden error #215

Closed roblevintennis closed 2 years ago

roblevintennis commented 2 years ago

Describe the bug ChoiceInput may be incorrectly using aria-hidden

To Reproduce Steps to reproduce the behavior:

  1. Run the playground application at playgrounds/SignupForm/src/components/react/React.jsx
  2. I had done npm run build && npm run preview but likely npm run dev would work too
  3. Apply Lighthouse to page

Expected behavior No Lighthouse errors

Screenshots

Looks like we're getting a:

[aria-hidden="true"] elements contain focusable descendants

image

roblevintennis commented 2 years ago

This should be fixed in all of the packages as of 5a80de0fb59df7963588e6b932bbd1489a32d927 -- I bumped package version numbers but haven't yet published these so the fixes are only in master not published npm packages (yet)