search

AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.
https://agnosticui.com
Apache License 2.0
723 stars 47 forks source link

Tooltips #248

Closed roblevintennis closed 1 year ago

roblevintennis commented 1 year ago

Tooltips for Vue, Svelte (the agnostic-svelte-ts project which I intend to supplant agnostic-svelte), React, and Astro.

Note this PR will not include the documentation fully which will need to happen once the NPM packages are updated.

netlify[bot] commented 1 year ago

Deploy Preview for agnostic-astro canceled.

Name Link
Latest commit dee6e1d616310b593f0b90185c226ed320d528bf
Latest deploy log https://app.netlify.com/sites/agnostic-astro/deploys/63c1bfb5fa140d0007ba83da
roblevintennis commented 1 year ago

Notes to Self :)

Since it's been several months I've decided to first off run each of the framework implementations to get my bearings and ensure this is working properly. Will post notes here for now…

React ✅

I got storybook and the examples verified for tooltips

Astro ✅

Ran local app and verified (looks like when I pushed this PR it redeployed to netlify.app for this branch (nice) of course the main one won't deploy until this PR is merged https://app.netlify.com/sites/agnostic-astro/settings/deploys

Svelte ✅

Note, this is only added to the agnostic-svelte-ts; so we probably need to also put some effort into determining if/how we can get Svelte Typescript Port to become the mainline for Svelte.

Verified the test app is in agnostic-svelte-ts/package_test and tooltips rendered and appear to work.

Considering publishing to https://www.npmjs.com/package/agnostic-svelte-ts

This would leave the https://www.npmjs.com/package/agnostic-svelte en tact while I get "my bearings" :-)

Vue

Vue verified -- agnostic-vue/package_test test app ran and we see tooltips properly.

Publish

We need to publish the NPM packages before we fully can update the documentation site and sandboxes

Documentation Site Updated?

UPDATE: Going to add on another PR since that depends on npm publishing to happen first

Go to site and run npm run docs:dev to view locally...we'll need to add Tooltips here ;)

Once this is merged to master we also need to verify if the Astro Netlify docs get built (or if that's another manual step)