AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.
https://agnosticui.com
Apache License 2.0
723 stars 47 forks source link

Fix breadcrumb template URL in Vue #257

Open pqnet opened 1 year ago

pqnet commented 1 year ago

Pull Request Template

Description

Binding of URL for breadcrumb items is not using the correct Vue syntax. The result is that the links are always pointing to the constant string {route.url}. Probably some copy/paste leftover from other code in JSX syntax.

This can also be seen in the documentation examples at

https://www.agnosticui.com/docs/components/breadcrumbs.html#examples

Hovering any one of the links will show the broken text instead of the expected target.

Checklist:

Please delete options that are not relevant.

We realize above checklist is pretty intimidating, reach out with an at mention on your issue if you're interested in contributing but need some clarifications!

netlify[bot] commented 1 year ago

Deploy Preview for agnostic-astro canceled.

Name Link
Latest commit 97e7e8cbb59b42ef08a8844e15a4840e44dd59e3
Latest deploy log https://app.netlify.com/sites/agnostic-astro/deploys/6451bff519154800071e31b4
cengique commented 7 months ago

@roblevintennis do you mind merging this in and posting a new release?