AgnosticUI / agnosticui

AgnosticUI is a set of UI primitives that start their lives in clean HTML and CSS. These standards compliant components are then copied to our framework implementations in: React, Vue 3, Angular, and Svelte.
https://agnosticui.com
Apache License 2.0
725 stars 47 forks source link

Dialog (2/14) #92

Closed roblevintennis closed 2 years ago

roblevintennis commented 2 years ago

Can we leverage a11y-dialog?

Can we share logic for Drawers and Toasts? TODO: research aria and a11y for drawers and toasts and see if the variation is small enough so that we can reuse logic.

This is now also including helping with upstream work on vue-a11y-dialog and creating a svelte-a11y-dialog and angular-a11y-dialog. It's actually much easier then getting the JavaScript correct from scratch, a11y-dialog is well maintained and battle-tested and finally light-weight

I'm removing following requirement for this task: ~- [ ] Still need to add Cypress tests to svelte-a11y-dialog then publish~

And moving that to the svelte-a11y-dialog tracker: https://github.com/AgnosticUI/svelte-a11y-dialog/issues/1

roblevintennis commented 2 years ago

angular-a11y-dialog

https://www.npmjs.com/package/angular-a11y-dialog "version": "0.0.4", "homepage": "https://github.com/AgnosticUI/angular-a11y-dialog",

And I've got it working in AgnosticUI angular package (not published in docs site yet)

svelte-a11y-dialog

https://www.npmjs.com/package/svelte-a11y-dialog

vue-a11y-dialog

https://github.com/AgnosticUI/vue-a11y-dialog/tree/vue-3

Was attempting to push back upstream. See discussion here: https://github.com/morkro/vue-a11y-dialog/issues/28

PR's been sitting for a while with no feedback: https://github.com/morkro/vue-a11y-dialog/pull/31 🤔

UPDATE: vue-a11y-dialog in morko is now updated and working!

roblevintennis commented 2 years ago

I'm electing to mark this task as DONE even though there are some minor loose ends:

  1. I plan to have test coverage added to the svelte-a11y-dialog adapter but I'm awaiting Vite + Cypress plugin support
  2. Angular dialog should be used for several months until it's considered ready and probably was given the least amount of effort

However, I want to close this out in the spirit of iteration and forward progress. I have stated in the docs for svelte and angular something to the affect of:

Please consider <Angular|Svelte> Dialog experimental and not yet ready for production

I'll get back to these things but want to feel unstuck and have started on Toasts for now :)