Closed Andrew-S-Rosen closed 1 year ago
Thanks, @wjcunningham7! I'll address that shortly and let you know when I'm done.
If you need to merge #41 first, let me know and I'll address any merge conflicts here.
@wjcunningham7 --- Alright! I added the necessary tests and everything passes locally.
Patch coverage: 43.75
% and project coverage change: +2.87
:tada:
Comparison is base (
f48c03d
) 47.89% compared to head (177c4bd
) 50.76%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@wjcunningham7 --- alright, should be ready to merge! Thanks for the help.
This PR resolves #45 by adding a new
cert_file
kwarg and generalizing theclient_keys
kwarg passed toasyncssh.connect()
. I have also cleaned up a few things related to the error-checking process when establishing the connection.It looks like there are some issues with the unit tests getting started via the GitHub actions. I could use some assistance in addressing that.