AgnostiqHQ / covalent-slurm-plugin

Executor plugin interfacing Covalent with Slurm
https://covalent.xyz
Apache License 2.0
27 stars 6 forks source link

Clarify remote dependencies and auto-apply "parsable" directive #53

Closed Andrew-S-Rosen closed 1 year ago

Andrew-S-Rosen commented 1 year ago

This PR closes #48 and does two things:

  1. Adds installation instructions related to dependencies on the remote machine.
  2. Auto-applies the parsable option if not set since this is required by covalent to read the queue status and other slurm information.

Once approved, I will make the same change in the covalent docs for the SLURM executor.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 :tada:

Comparison is base (65a71f3) 92.76% compared to head (f5c1e7d) 92.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #53 +/- ## =========================================== + Coverage 92.76% 92.82% +0.06% =========================================== Files 2 2 Lines 235 237 +2 =========================================== + Hits 218 220 +2 Misses 17 17 ``` | [Impacted Files](https://codecov.io/gh/AgnostiqHQ/covalent-slurm-plugin/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AgnostiqHQ) | Coverage Δ | | |---|---|---| | [covalent\_slurm\_plugin/slurm.py](https://codecov.io/gh/AgnostiqHQ/covalent-slurm-plugin/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AgnostiqHQ#diff-Y292YWxlbnRfc2x1cm1fcGx1Z2luL3NsdXJtLnB5) | `92.79% <100.00%> (+0.06%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Andrew-S-Rosen commented 1 year ago

This should be ready for your review, @wjcunningham7!