AgnostiqHQ / covalent-slurm-plugin

Executor plugin interfacing Covalent with Slurm
https://covalent.xyz
Apache License 2.0
27 stars 6 forks source link

Support for login without SSH key #59

Closed Andrew-S-Rosen closed 1 year ago

Andrew-S-Rosen commented 1 year ago

What should we add?

I think it would be nice to provide support for just username and password credentials without needing an SSH key. I'd personally never use it, but I'm thinking that it might help for folks who are less programming-inclined and may not be familiar with SSH keys. The downside is that their username and password are then stored as plaintext in the local config, so this shouldn't be done until a system is in place to better handle credential storage.

Describe alternatives you've considered.

No response

santoshkumarradha commented 1 year ago

This is again a great UX. We initially were considering this even for the first release (I personally always used to SSH with password haha)

It is crucial to consider more than just storing passwords as plain text. The issue lies in the fact that pickled objects and APIs now include passwords directly, which leaves room for potential interception. In the future, we plan to implement secrets management as a seamless solution. However, if you have any ideas for a somewhat secure way to add user-name and password in the interim, let us start a discussion, very open to it!