AgnostiqHQ / covalent-slurm-plugin

Executor plugin interfacing Covalent with Slurm
https://covalent.xyz
Apache License 2.0
27 stars 6 forks source link

[UnitaryHack] Expand kwargs from parent for better autodoc #68

Closed WingCode closed 1 year ago

WingCode commented 1 year ago

closes https://github.com/AgnostiqHQ/covalent/issues/1637

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff65dec) 85.76% compared to head (3f77039) 85.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #68 +/- ## ======================================== Coverage 85.76% 85.76% ======================================== Files 2 2 Lines 309 309 ======================================== Hits 265 265 Misses 44 44 ``` | [Impacted Files](https://app.codecov.io/gh/AgnostiqHQ/covalent-slurm-plugin/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AgnostiqHQ) | Coverage Δ | | |---|---|---| | [covalent\_slurm\_plugin/slurm.py](https://app.codecov.io/gh/AgnostiqHQ/covalent-slurm-plugin/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AgnostiqHQ#diff-Y292YWxlbnRfc2x1cm1fcGx1Z2luL3NsdXJtLnB5) | `85.71% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

WingCode commented 1 year ago

This CI job check failing because I changed the version. The PR template checklist asks me to update VERSION. Would like me to update the version as part of this PR?

Andrew-S-Rosen commented 1 year ago

My understanding is that you should leave the version as-is and it'll be updated automatically. The PR instructions are out of date. See https://github.com/AgnostiqHQ/covalent/issues/1626.

kessler-frost commented 1 year ago

Thanks @WingCode 🚀 !