AgnostiqHQ / covalent-slurm-plugin

Executor plugin interfacing Covalent with Slurm
https://covalent.xyz
Apache License 2.0
27 stars 6 forks source link

Make it possible for users to pass optional kwargs to `asyncssh.connect()` #80

Closed Andrew-S-Rosen closed 11 months ago

Andrew-S-Rosen commented 12 months ago

What should we add?

asyncssh.connect() takes many optional kwargs, most of which are not accessible to the user of covalent-slurm-plugin. While this is fine for most use cases, one can easily imagine some peculiar setups where additional kwargs are needed to establish the connection. In fact, I had such a scenario that was reported in https://github.com/ronf/asyncssh/issues/582. It would probably be worthwhile to make this accessible to the user, but I'm also weary of adding yet another parameter since at some point we don't want to overload the user with options.

Describe alternatives you've considered.

If a connection needs additional parameters to for authorization to be established on asyncssh.connect(), the only option is to make a custom fork of the plugin. This isn't necessarily as terrible an idea as it sounds seeing as it's so light-weight and is meant to be customizable.