Set `COVALENT_CONFIG_DIR` to `/tmp` to allow filelock on slurm clusters

araghukas commented 9 months ago

Fixes: https://github.com/AgnostiqHQ/covalent-slurm-plugin/issues/84

Added

export COVALENT_CONFIG_DIR=/tmp inside sbatch script to enable filelock

Changed

Aesthetics and string formatting

[ ] I have added the tests to cover my changes.
[x] I have updated the documentation, VERSION, and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (604a271) 93.11% compared to head (2be0f59) 93.16%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #85 +/- ## =========================================== + Coverage 93.11% 93.16% +0.04% =========================================== Files 2 2 Lines 276 278 +2 =========================================== + Hits 257 259 +2 Misses 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

santoshkumarradha commented 9 months ago

this is a smart fix. Thanks @araghukas.

Since I don't have immediate access to SLURM, where you able to run the test workflow with this ?

kessler-frost commented 9 months ago

Yes @santoshkumarradha , we tried running a basic workflow and were able to complete it successfully after this fix.

AgnostiqHQ / covalent-slurm-plugin