search

AgolaDeveloper / ReactRouting

0 stars 0 forks source link

Code review: From Djuma #1

Open DickensJuma opened 3 years ago

DickensJuma commented 3 years ago

Great start @AgolaDeveloper :clap:

Sites to help u

  1. https://html-css-js.com/
  2. https://css-tricks.com/snippets/css/complete-guide-grid/
  3. https://react-bootstrap.github.io/
  4. https://youtu.be/NMiEREulVLc
Navbar
AgolaDeveloper commented 3 years ago

I gotta check on the aforementioned areas, for improvement.

& Under your tutelage, I believe I'll go far

Agola

On Sun, Mar 21, 2021, 9:24 PM Dickens Juma @.***> wrote:

Great start @AgolaDeveloper https://github.com/AgolaDeveloper 👏

-

Nice work on the routing However, some requirements need to be implemented in order to improve the code quality for this project. Check ⬇️

[REQUIRED] Build user interfaces or UI components

Html Semantic

  • Index.js should be your entry point.
  • Import your components to app.js then import app.js to index.js- try being conventional
  • Use CSS, bootstrap, or any styling framework to make your user interface clean- that's the main purpose of React.
  • When using background images, make the text color contract so that it be readable

Sites to help u

  1. https://html-css-js.com/
  2. https://css-tricks.com/snippets/css/complete-guide-grid/
  3. https://react-bootstrap.github.io/
  4. https://youtu.be/NMiEREulVLc

Navbar

  • Work on creating a basic navbar

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AgolaDeveloper/ReactRouting/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASI4FMLRX4PSPLRH7XMG7KLTEY2UXANCNFSM4ZR2AKWQ .