Text printing does not explicitly ensure fillBackground glyph options

AgonConsole8 / agon-vdp

Official Firmware for the Agon Console8: ESP32 VDP

MIT License

38 stars 17 forks source link

Text printing does not explicitly ensure fillBackground glyph options #155

Closed stevesims closed 5 months ago

stevesims commented 7 months ago

When printing text at the graphics cursor, background fill should be disabled. Conversely, at the text cursor, text background fill should be enabled

vdp-gl provides a mechanism for this thru glyphOptions.fillBackground

We currently do not properly ensure that this happens. somehow it seems to work correctly, but if we look to improve our text rendering we should probably ensure we have better control over glyph options

stevesims commented 5 months ago

wrong :grin:

we do set this after all, explicitly when picking either text or graphics cursor

it's handled by the setCharacterOverwrite function