Terminal mode text deletion/overwrite can be broken

AgonConsole8 / agon-vdp

Official Firmware for the Agon Console8: ESP32 VDP

MIT License

38 stars 13 forks source link

Terminal mode text deletion/overwrite can be broken #194

Closed stevesims closed 3 months ago

stevesims commented 4 months ago

Problems have been observed in CP/M with VDP 2.7.1 - notably "delete" doesn't seem to work.

This problem appears to be the same as one observed in mode 7 in 2.7.0, caused by the new XOR-rendered cursor.

This can be fixed by ensuring that the painting mode is changed to "set" when enabling (or resuming) terminal mode. Either that or the cursor plotting can always change the painting mode back to "set" after rendering the cursor.

stevesims commented 4 months ago

potential fix is in #195

stevesims commented 3 months ago

fix released, and it worked :grin: