AgonConsole8 / agon-vdp

Official Firmware for the Agon Console8: ESP32 VDP
MIT License
43 stars 17 forks source link

Circles assume square pixels #57

Closed stevesims closed 1 year ago

stevesims commented 1 year ago

To draw circles we use the underlying fab-gl "ellipse" drawing, passing it an identical width and height.

This assumes (essentially) square pixels are being used.

That's not true for all of our screen modes. Some modes, such as those with a resolution of 640x240 (3-6 and 132-134), use "tall" pixels, and thus have an aspect ratio of 2:1. For those modes therefore we should be halving the height we pass to ellipse calls.