search

Agontuk / react-native-geolocation-service

React native geolocation service for iOS and android
https://www.npmjs.com/package/react-native-geolocation-service
MIT License
1.6k stars 291 forks source link

Consider bumping Android play-services version to 19 #333

Closed fiznool closed 2 years ago

fiznool commented 2 years ago

On Android, this package currently uses play-services-location v17 by default. This was originally released in June 2019. Since then, versions 18 and 19 have been released - looking through the release notes, there have been a few fixes to this dependency, including one in v18 that suppresses initial inaccurate results by default.

I understand it is possible to override the version used in a project by defining the googlePlayServicesVersion in the project gradle file, but since many people will not do this, perhaps it is time to consider bundling the latest version (19) of the play-services-location dependency by default?

cristianoccazinsp commented 2 years ago

Hey, what are the benefits of using v 19? I'm also using v18.

fiznool commented 2 years ago

I don't think there is anything different from a feature perspective. The major version bump is because the native library was changed to use 'strict null' annotations.

https://developers.google.com/android/guides/releases#december_09_2021

I don't imagine there are any real-world differences between using v18 and v19 for this package.

Agontuk commented 2 years ago

Thanks @fiznool for the info. I've updated the default version to 18.0.0 as v19 does not seem to have any location related changes. Closing this for now.