search

Agontuk / react-native-geolocation-service

React native geolocation service for iOS and android
https://www.npmjs.com/package/react-native-geolocation-service
MIT License
1.6k stars 291 forks source link

Update LocationProvider.swift #334

Closed tiempham closed 1 year ago

tiempham commented 2 years ago

Add didUpdateHeading to update heading when didUpdateLocations did not update heading on real devices

Agontuk commented 2 years ago

Hello, can you please make a new PR with your changes only ? It's hard to figure out the actual changes here. Also we can probably expose separate api to watch for heading changes, need to figure out which would be the best way to go.

tiempham commented 2 years ago

@Agontuk Can you help me merge file LocationProvider.swift, Only this file was changed. Sorry for this inconvenience.

Agontuk commented 2 years ago

You should make a new PR instead of editing this if you're having a problem rebasing. Also I don't think it's good idea to listen for heading change inside location api. Because location callbacks will be triggering constantly even if there's no position change. It would be better to expose it as a separate api.