Agontuk / react-native-geolocation-service

React native geolocation service for iOS and android
https://www.npmjs.com/package/react-native-geolocation-service
MIT License
1.61k stars 291 forks source link

Update setup.md - adding playServicesLocationVersion #436

Open Bilal-Abdeen opened 5 months ago

Bilal-Abdeen commented 5 months ago

The setup instructions suggest adding googlePlayServicesVersion, playServicesVersion or playServicesLocationVersion to the android/build.gradle file. Only using the last one playServicesLocationVersion works. The other 2 throw dependency errors.

Summary

  1. I updated the version numbers referenced in the setup instructions for the android/build.gradle file.
  2. Adding googlePlayServicesVersion or playServicesVersion throws an error while using playServicesLocationVersion works.

398

Test Plan

I tried using googlePlayServicesVersion and using playServicesVersion. In both scenarios, building the app (by executing npx react-native run-android) throws an error regarding dependencies. I used playServicesLocationVersion. The app was built successfully, and the current location was picked correctly.