AgoraDesk-LocalMonero / agoradesk-app-foss

Source code for the AgoraDesk/LocalMonero Mobile Applications. https://agoradesk.com
Apache License 2.0
138 stars 18 forks source link

Accessibility, more things #126

Closed davidbtc2009 closed 1 year ago

davidbtc2009 commented 1 year ago

Everything done below is with the talkback screen reader. Which can be enabled in the "Accessibility" section of android settings

Edit: i found another one

sergdeus commented 1 year ago

Outstanding job, thank you. Will be done with the next release.

davidbtc2009 commented 1 year ago

@sergdeus i found another one and added it to the bottom of the post

sergdeus commented 1 year ago

Thank you! Had some critical things to do. Next week will do this issue.

sergdeus commented 1 year ago

Hi! About this issue The password box is completely skipped on the login screen. See the username box focuses in screenshot 1, the show/hide password focuses in screenshot 2 and the one-time password (if enabled) focuses in screenshot 3.

I've tried accessibility mode with voice, and I should press this field and in this case, it works well.

How can I reproduce this issue?

davidbtc2009 commented 1 year ago

@sergdeus Odd. It is not working for me. I attempted tapping the box directly ans swiping right with one finger and could not access it.

Edit: is the coding different from the username box other than hiding the input? Because for me the username box is fine. I am on the version ending in .37 if that helps

sergdeus commented 1 year ago

@sergdeus Odd. It is not working for me. I attempted tapping the box directly ans swiping right with one finger and could not access it.

Edit: is the coding different from the username box other than hiding the input? Because for me the username box is fine. I am on the version ending in .37 if that helps

Yes, the coding is different. I've added an additional focus request for a password field. Please check does it help or not. I can't check, because I can tap into this field with the old code as well.

davidbtc2009 commented 1 year ago

@sergdeus nope. It would require a new app version to test

sergdeus commented 1 year ago

Yes, we will make a release tomorrow.

davidbtc2009 commented 1 year ago

@sergdeus. Okay, i will test it then

davidbtc2009 commented 1 year ago

@sergdeus So, the thing with the one time password box is now fixed. The password box is still skipped so i have unchecked it. The forgot password text is read, but the focus is wrong (see screenshot. It has the focus on the entire app and not the element itself. It looks like this, Screenshot_20221201-122245_LocalMonero When it should look more like this Screenshot_20221201-122645_Fennec See how only the text is focused in the green box? It is a seperate element. This is a problem in a few other places too, but we can get to those later. This may help. https://developer.android.com/guide/topics/ui/accessibility/

sergdeus commented 1 year ago

h the one time password box is now fixed. T

Ok., thank you. I think I definitely should learn to test it by myself as well. What is your Android version?

davidbtc2009 commented 1 year ago

@sergdeus Android 11

sergdeus commented 1 year ago

I've figured out how to use this feature. So, with the next update please check the Login, Sign up, and Reset password screens. If they are ok I'll move further.

davidbtc2009 commented 1 year ago

@sergdeus i will. Thanks for putting in the work. I know it can:t be easy dealing with this stuff

davidbtc2009 commented 1 year ago

@sergdeus FANTASTIC! They work now. Login screen is fine, reset screen is fine. Only issue is that the "confirm password" box on the register screen only says "password" instead of "confirm password" when using talkback. Otherwise perfect!

sergdeus commented 1 year ago

Great, thank you for testing. In the next release, I'll finish all other issues. For the new one - please open a separate thread.

davidbtc2009 commented 1 year ago

@sergdeus will do

davidbtc2009 commented 1 year ago

What about screenshot 11? It is still unchecked. Were they fixed?