AgoraIO-Community / VideoUIKit-ReactNative

A React Native package to simply integrate Agora Video Calling or Live Video Streaming to your app with just a few lines of code.
MIT License
93 stars 43 forks source link

Support for react-native-agora 4.0.0 #107

Closed nbonatsakis closed 1 year ago

nbonatsakis commented 1 year ago

Target device: (Note: simulators are not supported for running the UIKit)

App Info

Describe the issue

We are trying to update to the latest version of react-native-agora (4.0.0) and running into the following TypeScript errors using v4.0.2 of agora-rn-uikit:

node_modules/agora-rn-uikit/index.ts:5:32 - error TS2724: '"react-native-agora"' has no exported member named 'VideoRenderMode'. Did you mean 'VideoDenoiserMode'?

5 export {StreamFallbackOptions, VideoRenderMode} from 'react-native-agora';
                                 ~~~~~~~~~~~~~~~

  node_modules/react-native-agora/lib/typescript/AgoraBase.d.ts:3058:21
    3058 export declare enum VideoDenoiserMode {
                             ~~~~~~~~~~~~~~~~~
    'VideoDenoiserMode' is declared here.

node_modules/agora-rn-uikit/src/AgoraUIKit.tsx:29:10 - error TS2559: Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & Partial<RtcPropsInterface>'.

29         <RtcConfigure>
            ~~~~~~~~~~~~

node_modules/agora-rn-uikit/src/AgoraUIKit.tsx:37:16 - error TS2559: Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes'.

37               <RtmConfigure>
                  ~~~~~~~~~~~~

To Reproduce Steps to reproduce the behavior:

  1. Install latest version of both libraries.
  2. Run yarn tsc
EkaanshArora commented 1 year ago

Released with v5.0.0