search

AgoraIO-Community / VideoUIKit-ReactNative

A React Native package to simply integrate Agora Video Calling or Live Video Streaming to your app with just a few lines of code.
MIT License
95 stars 43 forks source link

RtcConnectionData uid doesn't accept string #81

Closed LinusU closed 2 years ago

LinusU commented 2 years ago

Target device: (Note: simulators are not supported for running the UIKit)

App Info

Describe the issue The TypeScript typings doesn't allow to pass uid as string, but I'm using string user ids in my application and the server signs the token with a string uid.

To Reproduce

<AgoraUIKit
  connectionData={{
    appId: '...',
    channel: '...',
    rtcToken: '...',
    // HERE IS THE ERROR
    rtcUid: 'my string user id'
  }}
/>

Screenshots n/a

EkaanshArora commented 2 years ago

String UIDs are not supported by the UIKit - please use integers.

LinusU commented 2 years ago

@EkaanshArora hmm, that is unfortunate since our server workflow tracks our users with string ids. Is there a specific reason why string ids aren't supported? Would a PR to fix this be acceptable, and is it something that I could work on?