search

AgoraIO-Extensions / Electron-SDK

Electron wrapper around the Agora RTC SDKs for Windows/macOS
MIT License
156 stars 75 forks source link

Remove unnesseray dependencies! #1182

Closed henrydf closed 2 weeks ago

henrydf commented 2 months ago

Is your feature request related to a problem? Please describe. Why this SDK requires some annoying things such as gulp* and ts-interface-checker in production dependencies?

Describe the solution you'd like Keep production dependencies clear.

Describe alternatives you've considered Or provide some pre-bundled version in dist or somewhere.

Additional context Current dependencies make bundle result mess.

guoxianzhe commented 2 months ago

@henrydf Thanks for your advice! Currently, gulp is necessary, this will download our c++ native modules when you install Electron-SDK. ts-interface-checker is necessary when we check some variables in runtime.

If you have any suggestions please leave a message.

henrydf commented 2 months ago

How about provide a prebuild version of js/ts files. Then I just need to bundle the prebuild result instead of 500+ dependencies.

guoxianzhe commented 2 months ago

@henrydf The main reason for this problem is gulp IMO. Maybe We can remove gulp in the future. I will talk with my team and make it happen in the feature. This gonna be a huge work to do and please wait my further progress.

henrydf commented 2 months ago

Glad to see it.

stale[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.