search

AgoraIO-Extensions / agora-rtc-react

Agora RTC React SDK
https://agoraio-extensions.github.io/agora-rtc-react/
MIT License
31 stars 11 forks source link

Typescript error when integrating with agora-rtc-sdk-ng #178

Closed yinjs closed 11 months ago

yinjs commented 11 months ago

What kind of problem do you need help?

Typescript error when integrating with agora-rtc-sdk-ng

Screenshot 2023-12-18 at 10 19 00
hyrious commented 11 months ago

I noticed agora-rtc-sdk-ng is bundled in agora-rtc-react, which means you should not install the former package and you should just import all your needed names from agora-rtc-react:

import AgoraRTC from 'agora-rtc-react'

@guoxianzhe Is this by design? If so you may update the README otherwise any internal change to agora-rtc-sdk-ng would break your example in README.

yinjs commented 11 months ago

@hyrious Thanks. Works properly after import AgoraRTC from 'agora-rtc-react'. import AgoraRTC, { AgoraRTCProvider } from "agora-rtc-react";

@hyrious @guoxianzhe Do you think it makes more sense to treat 'agora-rtc-sdk-ng' as a peer dependency?

guoxianzhe commented 11 months ago

@yinjs please check https://github.com/AgoraIO-Extensions/agora-rtc-react/issues/146

agora-rtc-react will as a standalone SDK in the future.