search

AgoraIO-Extensions / react-native-agora

React Native around the Agora RTC SDKs for Android and iOS agora
https://www.agora.io
MIT License
622 stars 228 forks source link

Screensharing Pod clarification #678

Closed EkaanshArora closed 12 months ago

EkaanshArora commented 1 year ago

@LichKing-2234 the react native SDK uses both, should it just use one? https://github.com/AgoraIO-Extensions/react-native-agora/blob/main/react-native-agora.podspec#L20-L21

just need to using native

Re: this comment, can we remove 'AgoraIrisRTC_iOS' is we're using only 'AgoraRtcEngine_iOS'?

LichKing-2234 commented 1 year ago

only in screen share extension

maxxfrazer commented 1 year ago

is the screen share extension using anything other than AgoraRtcEngine_iOS/ReplayKit?

it looks like it doesn't use AgoraRtcEngine_iOS/RtcBasic for example

Screen broadcast extension only needs AgoraRtcEngine_iOS/ReplayKit, so it's a very small extension now. Try to not include the whole AgoraRtcEngine_iOS pod, just the ReplayKit subspec.

EkaanshArora commented 1 year ago

Is our understanding correct—the RN SDK uses Iris Pod, but the extension uses the iOS Pod?

LichKing-2234 commented 1 year ago

Is our understanding correct—the RN SDK uses Iris Pod, but the extension uses the iOS Pod?

yes, RN SDK use iris and iOS pod, the extension just need to use the iOS pod

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.