AgoraIO-Extensions / react-native-agora

React Native around the Agora RTC SDKs for Android and iOS agora
https://www.agora.io
MIT License
625 stars 227 forks source link

V4 Migration Guide is pretty unclear #773

Closed anisurrahman072 closed 5 months ago

anisurrahman072 commented 7 months ago

I'm using Agora for last 2 years. All the code was working pretty well with version v3 (^3.7.0). Recently started the migration to v4 (^4.3.0-build.1). Found a migration guide. (Link)

I found that the MIGRATION guide of above is pretty unclear. Just want to share 1 example below 👇

In V3 I used this code & it was working pretty well 👇

import { RtcLocalView, VideoRenderMode } from 'react-native-agora'

return (
        <RtcLocalView.SurfaceView
        renderMode={VideoRenderMode.Hidden}
        zOrderMediaOverlay={false}
        zOrderOnTop={false}
        style={styles.rtcViewStyle}
    />
);

When I converted the version to v4 from package.json file, I see that all of these RtcLocalView, VideoRenderMode are stale. Ok great, but why they were not mentioned in the "Migration Guide" ?

This waste my time to identify, "Hey, what happened! Migration guide didn't specify it 😵‍💫 ".

My concern, did I miss any new Migration guide or some thing like that ? Or If I'm Ok, then what are the new code in V4 instead of above mentioned functions of V3 ?

@LichKing-2234 would you help here please ? We are a paid customer for last 2 years.

LichKing-2234 commented 7 months ago
import {
  RtcSurfaceView,
} from 'react-native-agora';

pls refer to https://docs.agora.io/en/video-calling/get-started/get-started-sdk?platform=react-native#handle-the-system-logic

anisurrahman072 commented 7 months ago

Thanks @LichKing-2234 for the link. Let me read it. Will it show all the changes for V4 ?

LichKing-2234 commented 7 months ago

Thanks @LichKing-2234 for the link. Let me read it. Will it show all the changes for V4 ?

just the usage for V4, if you want more changes, pls read https://docs.agora.io/en/video-calling/develop/migration-guide?platform=react-native

anisurrahman072 commented 7 months ago

Thanks @LichKing-2234 for the link. Let me read it. Will it show all the changes for V4 ?

just the usage for V4, if you want more changes, pls read https://docs.agora.io/en/video-calling/develop/migration-guide?platform=react-native

I paste this link in the ISSUE description already & this migration guide has very limited info !!!

Another example that was not defined in the migration guide 👇

Screenshot 2024-03-18 at 3 57 40 PM

There is no explanation of how can we do this for V4 ? As I see the functions here are deprecated in V4 !

anisurrahman072 commented 7 months ago

Hi @LichKing-2234, due to lack of proper migration guide, it really wasting dev times. Like I found all these changes in V4 by reading the huge big documentation deeply. It would be better if these changes were in Migration Guide 🐥

Only some of them were mentioned but max of them were not mentioned in the Migration Guide.

Screenshot 2024-03-18 at 5 37 29 PM
LichKing-2234 commented 7 months ago

Thanks @LichKing-2234 for the link. Let me read it. Will it show all the changes for V4 ?

just the usage for V4, if you want more changes, pls read https://docs.agora.io/en/video-calling/develop/migration-guide?platform=react-native

I paste this link in the ISSUE description already & this migration guide has very limited info !!!

Another example that was not defined in the migration guide 👇

Screenshot 2024-03-18 at 3 57 40 PM

There is no explanation of how can we do this for V4 ? As I see the functions here are deprecated in V4 !

await _engine.current.setCameraCapturerConfiguration({
cameraDirection: CameraDirection.Rear
})
stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.