search

AgoraIO-Extensions / react-native-agora

React Native around the Agora RTC SDKs for Android and iOS agora
https://www.agora.io
MIT License
625 stars 227 forks source link

Support PiP in IOS #791

Closed alejandro-geeksquare closed 1 month ago

alejandro-geeksquare commented 4 months ago

It is possible to enter PiP (Picture in picture) mode on IOS, we are connecting to the broadcast with RtcSurfaceView. Currently we have created a native module on Android that works correctly but on IOS we are using AVPictureInPictureController(playerLayer: playerLayer) but we cannot get it to detect the broadcast and enter PiP mode correctly. Thank you very much for the help

guoxianzhe commented 4 months ago

@alejandro-geeksquare . We are planning to release the PiP feature for the RN version, please wait for future updates.

alejandro-geeksquare commented 4 months ago

@alejandro-geeksquare . We are planning to release the PiP feature for the RN version, please wait for future updates.

thank you so much. We are waiting to test the new functionality, to implement it in our application

takuyanz commented 3 months ago

We are planning to release the PiP feature for the RN version, please wait for future updates.

@guoxianzhe any information about when this will be released ... ? 🤔

guoxianzhe commented 3 months ago

@takuyanz Currently, we are in development. Please wait for a while, and I will inform you once it is released.

vishalyad16 commented 2 months ago

@alejandro-geeksquare Does pip support Android? Can you share the documentation or sample code for reference ?

guoxianzhe commented 2 months ago

@vishalyad16 We will release pip soon, it will include Android and iOS.

guoxianzhe commented 1 month ago

Hi all, We are supported PiP in #820 v4.3.2-build.5-rc.1

Here is examples: https://github.com/AgoraIO-Extensions/react-native-agora/tree/special/4.3/example/src/examples/advanced/PictureInPicture

And we will support this feature >=4.5.0 too

NirajBharambe commented 1 month ago

Is there any documentation on the same? Also Do these type of versions in agora signify anything? [4.3.2-build.5-rc.1]

takuyanz commented 1 month ago

@guoxianzhe

Thanks for supporting PiP! 😄 I am just wondering the same thing as @NirajBharambe

Also Do these type of versions in agora signify anything?

Should I wait for 4.3.2-build.5-rc.1 to be merged into main branch before using PiP in production?

vishalyad16 commented 1 month ago

@guoxianzhe Thanks for the update! We’re definitely waiting for 4.3.2-build.5-rc.1 to be merged into the main branch before using PiP in production. Do you have any updates on when that might happen, or how we can use it in the meantime?

guoxianzhe commented 4 weeks ago

@takuyanz @vishalyad16 Yes, you can use it in production. I will update it into main in the future. I will let you guys know when I finsh.