search

AgoraIO / AgoraRtcEngine_iOS

iOS Package for Agora Video RTE SDK. Perfect for video calls and live streaming.
https://agoraio.github.io/AgoraRtcEngine_iOS/
MIT License
58 stars 17 forks source link

Fix SPM deployment target warning #10

Closed brow closed 2 years ago

brow commented 2 years ago

Removing the platforms parameter avoids this warning in projects that import the Swift package:

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.0.99.

A comparable PR in the SwiftyJSON repo explains why platforms is unnecessary when the minimum iOS deployment target is less than 9 under swift-tools-version:5.3.

Those platforms only specify minimum deployment target, if it is higher than minimum SPM deployment target. Thus if they are omitted, Swift Package will automatically support all platforms supported by current tools.

maxxfrazer commented 2 years ago

Hi @brow, the SDK currently supports iOS down to 8.0, removing this would unnecessarily bump the minimum supported iOS to 9.0. If we were to drop 8.0, it might be better to alter the platform to .iOS(.v9), rather than just removing it IMO.

If you still want Agora to remove support for iOS 8.0 in order to remove the Xcode warning, please open a ticket here, or by heading to console.agora.io and clicking "Support" at the top right. That's where decisions like this will be made, rather than directly on GitHub.

I'll leave this PR open, and please add the CUS code for your ticket here once it's created.

brow commented 2 years ago

Hi, @maxxfrazer! I mistakenly believed that it was already not possible to build for deployment target 8.0 with this Package.swift, even prior to my change. I agree with not casually removing support for that deployment target.

It looks like there are a couple of ways to fix the warning without breaking compatibility. Does one of those seem acceptable for this project?

maxxfrazer commented 2 years ago

Hi @brow, we went with just bumping it to .v9, as this package will only work on Xcode 12+, so you can't even target iOS 8 with this package to begin with! thanks for the PR, and that warning message should be gone for you now.