search

AgoraIO / AgoraRtcEngine_iOS

iOS Package for Agora Video RTE SDK. Perfect for video calls and live streaming.
https://agoraio.github.io/AgoraRtcEngine_iOS/
MIT License
58 stars 17 forks source link

Can you make this available as a pod? #27

Closed hawflakes closed 1 year ago

hawflakes commented 2 years ago

Have had CI issues pulling the official pod download link being flaky. Would it be possible to add a podspec so this can be used instead?

maxxfrazer commented 2 years ago

Which version of the pod are you trying to pull? There was an issue with the hosting server (download.agora.io) a couple of weeks ago, but that should be resolved now.

hawflakes commented 2 years ago

We're using 3.x. Is there a place to see system status for download.agora.io? If we can't be notified we can't really rely on it for ci builds which were broken for several days. We wound up making a private mirror repo to get unstuck.

Having this on GitHub would make life a little less messy if downloads.agora.io can't be relied upon and there's no clear way to tell if it's unavailable/semi-stable.

maxxfrazer commented 2 years ago

Hosting on GitHub is great IMO, and that's actually how the first version of this package worked when it was created. But not applicable to all the platforms we support, so we'd end up hosting iOS/macOS here, and everything else on our downloads server.

Let's see if @plutoless has any input there.

Which 3.x version exactly are you looking for, and when did it last have a problem (or is it constant and happening right now)? AFAIK download.agora.io had an unusual error that was fairly quickly resolved. There's no official way to check system status other than an old fashioned ping unfortunately.

hawflakes commented 2 years ago

Sorry for the delay, @maxxfrazer We're currently using 3.7.0.3!

hawflakes commented 2 years ago

D'oh looks like we hit 10/1 National Day so it'll be a while before @plutoless will be around.

hawflakes commented 2 years ago

@maxxfrazer @plutoless I know you guys are probably busy at RTE 2022 but would be great together an update!

plutoless commented 2 years ago

sorry for late reply. i don't quite get the question. this sdk is already available as pod? you can use pod 'AgoraRtcEngine_iOS', '3.7.1' in your podfile. does this answer your question？

hawflakes commented 2 years ago

No, it doesn't quite address the issue we had. Your site was down and our builds broke. There's no way we knew of your site outage and so all we could do is make our own mirror. If you provided a podspec in this repo we'd be able to install the pod from your GitHub repo. Does that make sense?

maxxfrazer commented 2 years ago

@plutoless looks like @hawflakes's issue was more to do with the SDK not downloading properly from downloads.agora.io when trying to install (regardless of swiftpm or cocoapods)

This repo actually downloads from the same address: https://github.com/AgoraIO/AgoraRtcEngine_iOS/blob/1b4cf5214d5c3d3fa5735f48ba26e26f2f75bacf/Package.swift#L25

But one solution could be uploading those as artefacts on the release with GitHub, as done with previous versions from quite a while ago such as this one: https://github.com/AgoraIO/AgoraRtcEngine_iOS/releases/tag/3.3.0

Note they're not added to any commit, just the release, which means it won't bloat the repository itself.

plutoless commented 2 years ago

ok i can try talking to sdk team abt this.

hawflakes commented 2 years ago

多谢 Orz

hawflakes commented 1 year ago

@plutoless 🛎️ any updates?

plutoless commented 1 year ago

@hawflakes they are still discussing this. i'll let you know once updated.

hawflakes commented 1 year ago

@plutoless @maxxfrazer we've hit some outage again. Is there really nowhere where you post the status of downloads.agora.io? This is getting pretty old.

plutoless commented 1 year ago

@hawflakes we are working on the github backup solution, btw, is there any chance you can provide your network information and time/logs when the outage happened so that we can investigate further with this issue?

hawflakes commented 1 year ago

@plutoless thanks for the update. I don't have that solution as we are either building locally or using CI. I can try to dig up those CI builds that failed if that helps.

plutoless commented 1 year ago

@hawflakes for sure it helps! would be ideal if you can provide these to help us improve availability of our global download link :)

hawflakes commented 1 year ago

@plutoless I checked and basically all of our builds from 2022/9/15 failed in CI. They stopped failing because we switched to using our own clone.

We switched back and it's been working fine recently until about two days ago one local developer build broke trying to download it.

hawflakes commented 1 year ago

@plutoless 已经一个多月了。请问有没有消息呢？ It's been over a month. Any updates?

hawflakes commented 1 year ago

@plutoless Happy New Year. Any news before 春节？

arifbd commented 1 year ago

=== January 2023 === pod 'AgoraRtcEngine_iOS', '~> 4.1.0'

hawflakes commented 1 year ago

@arifbd yes, that works until download.agora.io goes down. This issue is asking to host the pod here on Github.

maxxfrazer commented 1 year ago

@hawflakes have you had any problems recently with this? I'll bring it up internally again, but wanted to check-in with you on it.

hawflakes commented 1 year ago

Thanks. Haven't had issues recently. No one ever did respond even after new year. 🤔

maxxfrazer commented 1 year ago

Going to close this issue - we're still considering updating the CI process to upload to GitHub, but there's a bit of reluctancy to host it on a 3rd party's servers instead of our own.