search

AgoraIO / Docs-Source

A repository for the Agora Docs source content.
MIT License
20 stars 11 forks source link

Flutter Quickstart overly complicated #1549

Closed tadaspetra closed 3 weeks ago

tadaspetra commented 6 months ago

A general comment about the Flutter quickstart is that it is overly complicated for being a "quick start". The messageCallback and eventCallback seem to be an opinionated messaging system built along with the quickstart. This seems to be an extra feature, that is unnecessary to start.

Not only that, those functions are not covered anywhere on this page. So, if a user copies all the code into their project, they will have errors.

Removing this messaging system would remove about 75% of the code in this snippet, making it much more readable. Any gaps left by this can be filled in with a paragraph above.

Screenshot 2024-05-28 at 2 10 11 PM

There are other examples of unnecessary code throughout the document. For example int localUid = -1 is declared, but never used. Same thing with isBroadcaster.

atovpeko commented 4 weeks ago

@tadaspetra I can't find this page in the current docs. Can you please check if there is still an issue?

tadaspetra commented 3 weeks ago

you are right, it's no longer there