search

Agorex-io / New-UI

GNU Affero General Public License v3.0
1 stars 0 forks source link

Initial setup of filterbox on popover. #5

Open JonathonDunford opened 6 years ago

JonathonDunford commented 6 years ago

Issue by trigunshin Wednesday Jan 17, 2018 at 22:02 GMT Originally opened as https://github.com/forkdelta/nextgen-ui/pull/10

Did PairFilterBox pretty quick, open to refactors.

Styling's very basic; good-enough?

trigunshin included the following code: https://github.com/forkdelta/nextgen-ui/pull/10/commits

JonathonDunford commented 6 years ago

Comment by freeatnet Thursday Jan 18, 2018 at 22:24 GMT

image

I think we're on the right track UI-wise. I've thrown a bit of styling overtop the component, seen above. Does it look right to you?

Styling as seen:

  1. Add .pt-input to the search field. Override .pt-input[type="search"] border-radius to use default for input components.
  2. Wrap that in a .pt-input-group .pt-large (see: http://blueprintjs.com/docs/v1/#core/components/forms/input.search-field)
  3. Wrap that in a <div> with style padding: 6px 8px; box-shadow: inset 0 0 0 1px rgba(16, 22, 26, 0.2), 0 0 0 rgba(16, 22, 26, 0), 0 1px 1px rgba(16, 22, 26, 0.4);
JonathonDunford commented 6 years ago

Comment by trigunshin Friday Jan 19, 2018 at 03:20 GMT

I can move the filterstate into redux, sure. Initially I wasn't sure that it'd need the wider scope, but being able to share the filter/selection from the popover box to any other select dialog would be kind of nice. I should get some time for that tomorrow afternoon.