Agoric / agoric-3-proposals

Proposals run or planned for Mainnet (agoric-3)
Apache License 2.0
1 stars 6 forks source link

introducing an alternative to `waitForBlock` #181

Open anilhelvaci opened 2 months ago

anilhelvaci commented 2 months ago

Context

@dckc has raised in here that waitForBlock might be racy and pointed some good implementations for an alternative:

Considerations

What do you think if we include one of the above to @agoric/synthetic-chain ? @turadg

dckc commented 2 months ago

I suggest that the title should be something like: waitForBlock(N) is unreliable for synchronization

As stated, any alternative would address the issue, including one that was functionally identical but refactored in some way.

turadg commented 2 months ago

What do you think if we include one of the above

First implement it locally in a proposal test. If it works well then we can incorporate it upstream.

any alternative would address the issue, including one that was functionally identical but refactored in some way

This would be ideal so the existing uses get automatically improved and no tests have to change.

anilhelvaci commented 2 months ago

Thanks, I'm clear now.