search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
327 stars 207 forks source link

remove getDisplayInfo() #10235

Open turadg opened 1 month ago

turadg commented 1 month ago

What is the Problem Being Solved?

It complicates adding asset types because it's metadata that isn't available on-chain for the Issuer/Brand creation to read from.

https://github.com/Agoric/agoric-sdk/blob/7940ef4c491777cfa333695f71a4767a8e5d4731/packages/orchestration/src/orchestration-api.ts#L109-L121

Related:

Description of the Design

Provide a metadata source for UIs to look up decimalPlaces. published.boardAux provides that now but it's only available in chainStorage.

addAssetToVault needs a source of truth for "unit amounts" to compare different assets by a consistent scale of unit.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

dckc commented 1 month ago

it's metadata that isn't available on-chain

help me understand that? Seems like it is available, using exactly this API E(brand).getDisplayInfo(). (or E(issuer).getDisplayInfo())