Closed 0xpatrickdev closed 4 days ago
Latest commit: |
3771e7f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d3aaff76.agoric-sdk.pages.dev |
Branch Preview URL: | https://pc-fusdc-fees.agoric-sdk.pages.dev |
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.
refs: #10390
Description
FeeConfig
toprivateArgs
so deployers can adjust fees over time (terms are immutable)FeeTools
for calculating net advance and fee splitsFeeTools
withAdvancer
Security Considerations
None really for these specific changes. We might need to think about timing from when the
Advancer
callscalculateAdvance
and theSettler
callscalculateSplit
, as theFeeConfig
values might change.From a product POV, users might pay more in fees than the net advance they receive. So we might consider a config parameter for a "minimum request amount".
Scaling Considerations
None really, mainly contains AmountMath computation.
Documentation Considerations
Includes jsdoc and code comments
Testing Considerations
Includes unit tests for FeeTools, attempting to cover all foreseeable scenarios. A bit light on testing integrations with the advancer and settler.
Upgrade Considerations
N/A, unreleased