search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
327 stars 207 forks source link

feat: upgrade v7-board and test it #10516

Open Chris-Hibbert opened 4 days ago

Chris-Hibbert commented 4 days ago

closes: #10394

Description

Upgrade v7-board.

Security Considerations

The Board is a critical vat.

Scaling Considerations

v7-Board is consuming more resources than it should. restarting it should clean up a fair amount of space. ...checking

Documentation Considerations

None

Testing Considerations

Verify that the board doesn't lose anything.

Upgrade Considerations

Can go out in Upgrade 19.

Chris-Hibbert commented 3 days ago

Would you please clarify that this is on purpose? Do we have other plans (mainfork?) for testing that?

Sorry, I wrote "restarting it should clean up a fair amount of space. ...checking", meaning that I intend to see if approaches like I used in #9595 would show some improvement. I'll do that next.

Chris-Hibbert commented 3 days ago

Well I get a count of 422 before in a3p-integration, and 432 after, using a query like this (with vatID = 7).

    sql.get([`SELECT COUNT(*) from kvStore WHERE key LIKE '${vatId}.c.%'`]);

I don't know what objects are soaking up space on mainnet, but they're not in evidence here.

@mhofman @warner Is there anything else worth checking in a3p-integration?