Closed michaelfig closed 2 days ago
Latest commit: |
266117a
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5af7c2bd.agoric-sdk.pages.dev |
Branch Preview URL: | https://mfig-nitpicking.agoric-sdk.pages.dev |
consider doing this in a way that doesn't require changing required checks config [and] making PRs have to merge this and rerun to get to green.
I was considering not marking this as a required check for master
until it's been on master
long enough that the only PRs needing to merge it are those needing to update anyway.
I was considering not marking this as a required check for
master
until it's been onmaster
long enough that the only PRs needing to merge it are those needing to update anyway.
IME some PRs get revived after a very long time. This repo has 252 open PRs dating back 3 years. No matter what time window you adopt there's a risk of merges to master in which the tests are failing.
lint-rest and lint-docs both take 4m. 0.5min of that is warmup so they may take less than 8 min combined. That's less than test-inter-protocol.
Incidental
Description
Independent changes that are best reviewed commit-by-commit:
@agoric/builders
to use, since it is published to NPM and has a hard dependency on@agoric/fast-usdc
proposal_id
and fix the "propsal [sic]" typolint-primary
doc generation to rebalance (since it was the longest-running non-integration ci job)Security Considerations
n/a
Scaling Considerations
Slightly faster CI times.
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
n/a