Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
327 stars 207 forks source link

chore: minor nitpicking #10525

Closed michaelfig closed 2 days ago

michaelfig commented 3 days ago

Incidental

Description

Independent changes that are best reviewed commit-by-commit:

Security Considerations

n/a

Scaling Considerations

Slightly faster CI times.

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

n/a

cloudflare-workers-and-pages[bot] commented 3 days ago

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 266117a
Status: ✅  Deploy successful!
Preview URL: https://5af7c2bd.agoric-sdk.pages.dev
Branch Preview URL: https://mfig-nitpicking.agoric-sdk.pages.dev

View logs

michaelfig commented 2 days ago

consider doing this in a way that doesn't require changing required checks config [and] making PRs have to merge this and rerun to get to green.

I was considering not marking this as a required check for master until it's been on master long enough that the only PRs needing to merge it are those needing to update anyway.

turadg commented 2 days ago

I was considering not marking this as a required check for master until it's been on master long enough that the only PRs needing to merge it are those needing to update anyway.

IME some PRs get revived after a very long time. This repo has 252 open PRs dating back 3 years. No matter what time window you adopt there's a risk of merges to master in which the tests are failing.

lint-rest and lint-docs both take 4m. 0.5min of that is warmup so they may take less than 8 min combined. That's less than test-inter-protocol.