search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
326 stars 206 forks source link

remove unused rollup dependency from several packages #1223

Open warner opened 4 years ago

warner commented 4 years ago

We have a leftover devDependency on rollup in several packages. I think I saw it in:

We stopped creating bundles in yarn build steps recently, and I removed the package.json build steps which did that, but I think I missed some of the support machinery.

The task is to make sure we don't really need it anymore, and delete the lines from our package.json files.

tonymade8 commented 3 years ago

singa

tonymade8 commented 3 years ago

S.O.S

tonymade8 commented 3 years ago

pp0ppp

tonymade8 commented 3 years ago

2

We have a leftover devDependency on rollup in several packages. I think I saw it in:

  • cosmic-swingset
  • eventual-send
  • swingset
  • transform-metering
  • acorn-eventual-send

We stopped creating bundles in yarn build steps recently, and I removed the package.json build steps which did that, but I think I missed some of the support machinery.

The task is to make sure we don't really need it anymore, and delete the lines from our package.json files.

read soon

tonymade8 commented 3 years ago

read out loud

turadg commented 1 year ago

@warner is there still work to do here? I see rollup is only in package.json of xsnap-lockdown, which I think you made recently.