Open warner opened 3 years ago
We put a bandage on this in #3024, but we need to make a thorough check of all the assertions and make sure they kill only the appropriate level.
Is there more to do on this for today's release? If not, I'd like to postpone it to a later milestone.
I don't think there's more to do on this for the Staking Dynamics milestone. We'll just have to see if the #3024 bandage makes a difference.
We may have fixed the initial error, but what should we do if it DOES happen again?
Describe the bug
While testing, I saw the comms vat get terminated when it received an unexpected seqnum. The slog trace was:
I'm pretty sure it's happening here: https://github.com/Agoric/agoric-sdk/blob/8b704bbb0be119c1acb35f92b3b6df3eeef43780/packages/SwingSet/src/vats/comms/delivery.js#L139-L143
I'm not exactly sure why this caused the comms vat to terminate, but I think it's because we decided that any unhandled error from
dispatch
qualifies as an internal error and kills the vat.The tasks are: