Open katelynsills opened 2 years ago
@katelynsills i would like to work on this, please assign this to me.
Hi @namangirdhar16, consider yourself assigned (We can only officially assign people in our Github organization, so the "assignee" will remain blank. Let me know if you have any questions! I think this will require a number of different PRs in each of the different repositories (dapp-card-store, etc.)
@katelynsills i guess i understand what needs to be done here, for the sake of confirmation i would like to ask do i just need to go in each project folder and update the package.json file with node version greater than 14?
Yes, that's right!
Thanks!!
@katelynsills in the package.json of this project, the node version is already updated to the desired one.
Yup, you're right. We need to make sure all of the dapps are updated, which have their own repos, like https://github.com/Agoric/dapp-fungible-faucet
Ok got it!, but there is no such issue in these dapps repo, should i create one and then make a PR, is it possible somehow to refercence this issue in other repos or should i just go with a new one? Thanks for the quick response btw.
Ok got it!, but there is no such issue in these dapps repo, should i create one and then make a PR, is it possible somehow to refercence this issue in other repos or should i just go with a new one? Thanks for the quick response btw.
Just referencing this issue is fine, but I appreciate the issues and PRs that you've made! Thank you so much!
Note that our minimum Node is presently 14.17.0. When we get to this we should also update other references to the required version. https://github.com/Agoric/agoric-sdk/pull/4460#issuecomment-1030422275
What is the Problem Being Solved?
In our dapps, if the Node version is below 14, we get a mysterious error message:
We need to improve the error message to point users to the appropriate Node version.
Description of the Design
Add
to the
package.json
in the root folder of the dapps.This gives a much better error message:
Security Considerations
None
Test Plan
None
List of dapps: