search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
327 stars 206 forks source link

Port inbound action checks from pismo to vaults #7187

Open mhofman opened 1 year ago

mhofman commented 1 year ago

What is the Problem Being Solved?

For Pismo, we added inbound action checks in https://github.com/Agoric/agoric-sdk/pull/7018

We need to port these checks to master and upgrade them for vaults offer shape.

Test Plan

TBD: how to determine all possible offer shapes

ivanlei commented 1 year ago

To add support to vaults actions, the code can use a set of endo patterns to validate object properties and the keywords from the schema can be added to the allowlist. A unit test can be used to ensure keywords in the schema are found on the allowlist.